Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/adding dart support #246

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

stefaniereuter
Copy link

This is related to ECC-1922 , to add support for Fesom grid DART . This is relevant for intermediate climate DT runs with FESOM.

@FussyDuck
Copy link

FussyDuck commented Sep 20, 2024

CLA assistant check
All committers have signed the CLA.

@stefaniereuter
Copy link
Author

I initially thought that C and N stands for Core2 and NG5 in subgridType but I then found a comment from Willem that it actually stands for centroids and edges i.e. the second commit that removes the D

@shahramn
Copy link
Collaborator

@stefaniereuter You need to sign the CLA (Contributor License Agreement) before we can proceed.
Vielen Dank

@dsarmany
Copy link

I initially thought that C and N stands for Core2 and NG5 in subgridType but I then found a comment from Willem that it actually stands for centroids and edges i.e. the second commit that removes the D

Yes, that is correct. So the combined changes in this PR are fine. It will be probably be worth squashing them into a single commit at the point of merging it.

@stefaniereuter
Copy link
Author

Hi Sharam, sorry I had already signed it but I did not click on rechecking. For me it now says all committers signed... So I assume it worked

@shahramn
Copy link
Collaborator

shahramn commented Sep 23, 2024

The last three entries in this table should be prefixed by a string like FESOM
e.g.,

'FESOM_CORE2' = { numberOfGridUsed = 8; }
'FESOM_NG5'   = { numberOfGridUsed = 9; }
'FESOM_DART' =  { numberOfGridUsed = 10; }

Note how the other names have the ORCA substring.

Really this kind of naming should be the responsibility of Data Governance

@stefaniereuter
Copy link
Author

I've just contacted Data Governance. I'll create a ticket in their jira space and will let you know what they say.

@mjg41 mjg41 self-requested a review September 25, 2024 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants